On 06/16/2014 01:43 PM, Stefano Stabellini wrote:
On Fri, 13 Jun 2014, Daniel Kiper wrote:efi_set_rtc_mmss() is never used to set RTC due to bugs found on many EFI platforms. It is set directly by mach_set_rtc_mmss(). Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx> --- arch/x86/platform/efi/efi.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index deb4f05..bd3e080 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -244,6 +244,11 @@ static efi_status_t __init phys_efi_set_virtual_address_map( return status; } +#if 0 +/* + * efi_set_rtc_mmss() is never used to set RTC due to bugs found + * on many EFI platforms. It is set directly by mach_set_rtc_mmss(). + */ int efi_set_rtc_mmss(const struct timespec *now) { unsigned long nowtime = now->tv_sec; @@ -279,6 +284,7 @@ int efi_set_rtc_mmss(const struct timespec *now) } return 0; } +#endif"Commenting out" code like that is not a good idea: it leaves dead-rotting functions in the middle of your source file. If the function is not used, just go ahead and remove it. We can use git to get it back.
And shouldn't it be removed from include/linux/efi.h as well? Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
