On Fri, 2014-04-04 at 13:25 +0100, Leif Lindholm wrote: > Add a wrapper for printk to standardize the prefix for informational and > error messages from the EFI stub. [] > diff --git a/drivers/firmware/efi/efi-stub-helper.c b/drivers/firmware/efi/efi-stub-helper.c [] > @@ -33,6 +33,9 @@ static void efi_printk(efi_system_table_t *sys_table_arg, char *str) [] > +#define pr_efi(sys_table, msg) efi_printk(sys_table, "EFI stub: "msg) > +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg) [] > @@ -486,7 +489,7 @@ static efi_status_t efi_relocate_kernel(efi_system_table_t *sys_table_arg, > &new_addr); > } > if (status != EFI_SUCCESS) { > - efi_printk(sys_table_arg, "ERROR: Failed to allocate usable memory for kernel.\n"); > + pr_efi_err(sys_table_arg, "ERROR: Failed to allocate usable memory for kernel.\n"); Author! Author! "ERROR: ERROR:"! One too many "ERROR:" prefixes. -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html