On Fri, 2012-10-12 at 20:21 +0100, Matt Fleming wrote: > This is a common idiom used throughout the kernel to simply error paths. > As you noted, calling kfree(NULL) is harmless and there's certainly no > need to worry about the overhead of calling kfree() without doing any > freeing since the error path is also the slow path. A "return -ENOMEM" looks simpler and easier to read to me, but that is a subjective opinion :) -- Khalid -- To unsubscribe from this list: send the line "unsubscribe linux-efi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html