Steven Toth wrote: > Mijhail Moreyra wrote: >> Steven Toth wrote: >>> Mijhail, >>> >>> http://linuxtv.org/hg/~stoth/cx23885-audio >>> >>> This tree contains your patch with some minor whitespace cleanups and >>> fixes for HUNK related merge issues due to the patch wrapping at 80 >>> cols. >>> >>> Please build this tree and retest in your environment to ensure I did >>> not break anything. Does this tree still work OK for you? >>> >>> After this I will apply some other minor cleanups then invite a few >>> other HVR1500 owners to begin testing. >>> >>> Thanks again. >>> >>> Regards, >>> >>> Steve >> >> Hi, sorry for the delay. >> >> I've tested the http://linuxtv.org/hg/~stoth/cx23885-audio tree and it >> doesn't work well. >> >> You seem to have removed a piece from my patch that avoids some register >> modification in cx25840-core.c:cx23885_initialize() >> >> - cx25840_write(client, 0x2, 0x76); >> + if (state->rev != 0x0000) /* FIXME: How to detect the bridge >> type ??? */ >> + /* This causes image distortion on a true cx23885 >> board */ >> + cx25840_write(client, 0x2, 0x76); >> >> As the patch says that register write causes a horrible image distortion >> on my HVR-1500 which has a real cx23885 (not 23887, 23888, etc) board. >> >> I don't know if it's really required for any bridge as everything seems >> to be auto-configured by default, maybe it can be simply dropped. >> >> Other than that the cx23885-audio tree works well. >> >> WRT the whitespaces, 80 cols, etc; most are also in the sources I took >> as basis, so I didn't think they were a problem. > > That's a mistake, I'll add that later tonight, thanks for finding this. > I must of missed it when I had to tear apart your email because of HUNK > issues caused by patch line wrapping. > > Apart from this, is everything working as you expect? > > Regards, > > Steve > > OK. And sorry about the patch, I didn't know it was going to be broken that way by being sent by email. >> Other than that the cx23885-audio tree works well. Regards, Mijhail Moreyra _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
