Re: DVICO firmware compatibility between v4l-dvb and in-tree kernel drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi i tested your patch on kernel 2.6.26 and it stopped the the error messages and appeared to load like normal in dmesg
however i cannot get a lock on channels either just wanted to say good work and am eagerly watching your progress

On Mon, Jul 28, 2008 at 4:29 PM, Robert Lowery <rglowery@xxxxxxxxxxxxxx> wrote:
Closing the loop in some findings related to this issue.

> Hi Folks,
>
> I've been successfully using the experimental v4l-dvb tree DVICO Dual
> Digital 4 drivers for a number of months.  Today I decided to try an use
> the official 2.6.26 kernel drivers, but they are triggering an OOPS at
> firmware load time (see below).  Can someone please confirm if the
> xc3028-dvico-au-01.fw  firmware is still compatible with 2.6.26? or are
> there any other known issues in this space?
>
> Thanks
>
> -Rob

I think I've found the cause of the oops.  It relates to the change below.

> /drivers/media/common/tuners/tuner-xc2028.c
> -       video_dev = cfg->i2c_adap->algo_data
> ...
> +               priv->video_dev = ((fe->dvb) && (fe->dvb->priv)) ?
> +                                  fe->dvb->priv :
cfg->i2c_adap->algo_data;

fe->dvb->priv is a dvb_usb_adapter, but the callback using priv->video_dev
is expecting a dvb_usb_device.  I'm not sure the best way to handle this
as
tuner-xc2028.c does not know about any dvb-usb code currently.  In any
case, the following patch seems to get it past the oops until the proper
fix is in place.  (I'm now having some tuning issues which I will
investigate separately).  I've sent these details to the author of the
broken patch for feedback.

--- cxusb.c.orig        2008-07-27 23:43:30.000000000 +1000
+++ cxusb.c     2008-07-27 23:44:02.000000000 +1000
@@ -490,7 +490,7 @@

 static int dvico_bluebird_xc2028_callback(void *ptr, int command, int
arg)
 {
-       struct dvb_usb_device *d = ptr;
+       struct dvb_usb_device *d = ((struct dvb_usb_adapter *)ptr)->dev;

       switch (command) {
       case XC2028_TUNER_RESET:

Next step for me is to investigate the tuner lock failures.

Cheers

-Rob


>
> [  103.974543] xc2028 1-0061: Loading 3 firmware images from
> xc3028-dvico-au-01.fw, type: DViCO DualDig4/Nano2 (Australia), ver 2.7
> [  103.984657] BUG: unable to handle kernel NULL pointer dereference at
> 00000000
>
> [  103.984690] IP: [<c0361a85>]
> __mutex_lock_interruptible_slowpath+0x35/0xe0
> [  103.984716] *pde = 00000000
> [  103.984731] Oops: 0002 [#1] SMP
> [  103.984742] Modules linked in: nfsd auth_rpcgss exportfs speedstep_lib
> cpufre
> q_conservative cpufreq_powersave cpufreq_userspace cpufreq_ondemand
> cpufreq_stat
> s freq_table container video output sbs sbshc battery nfs lockd nfs_acl
> sunrpc i
> ptable_filter ip_tables x_tables xfs ac lp tuner_xc2028 zl10353
> dvb_usb_cxusb dv
> b_usb snd_maestro3 dvb_core snd_ac97_codec serio_raw ac97_bus
> snd_seq_dummy psmo
> use snd_seq_oss snd_seq_midi snd_pcsp snd_rawmidi snd_pcm_oss
> snd_mixer_oss snd_
> pcm snd_seq_midi_event snd_seq snd_page_alloc snd_timer snd_seq_device snd
> butto
> n i2c_viapro soundcore i2c_core shpchp pci_hotplug via686a via_agp
> parport_pc pa
> rport agpgart ipv6 evdev ext3 jbd mbcache sg sr_mod cdrom sd_mod pata_acpi
> flopp
> y pata_sil680 sym53c8xx ehci_hcd e100 uhci_hcd pata_via ata_generic mii
> usbcore
> scsi_transport_spi libata scsi_mod dock thermal processor fan fbcon
> tileblit fon
> t bitblit softcursor uvesafb cn fuse
> [  103.984962]
> [  103.984971] Pid: 6492, comm: kdvb-fe-0 Not tainted (2.6.26-4-generic
> #1)
> [  103.984981] EIP: 0060:[<c0361a85>] EFLAGS: 00010246 CPU: 1
> [  103.984998] EIP is at __mutex_lock_interruptible_slowpath+0x35/0xe0
> [  103.985009] EAX: f6783d30 EBX: f7aa0c5c ECX: f7aa0c64 EDX: 00000000
> [  103.985020] ESI: f670d400 EDI: f7aa0c60 EBP: f6783d90 ESP: f6783d2c
> [  103.985031]  DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0068
> [  103.985040] Process kdvb-fe-0 (pid: 6492, ti=f6782000 task=f670d400
> task.ti=f
> 6782000)
> [  103.985050] Stack: f7aa0c64 f7aa0c64 00000000 c029e80f f6783d90
> 00000003 f7aa
> 0720 f6783d90
> [  103.985074]        f8b43b79 f6755d55 00000030 f8cbbaa5 f8cbdb14
> 0001d729 f7aa
> 0c5c 00000061
> [  103.985094]        f6783d90 f6783dcf f6783d93 f6783db8 f8b84251
> f6783dcf 0000
> 0001 00000000
> [  103.985114] Call Trace:
> [  103.985129]  [<c029e80f>] release_firmware+0xf/0x20
> [  103.985165]  [<f8b43b79>] dvb_usb_generic_rw+0x69/0x190 [dvb_usb]
> [  103.985202]  [<f8cbbaa5>] load_all_firmwares+0x415/0x740 [tuner_xc2028]
> [  103.985244]  [<f8b84251>] cxusb_ctrl_msg+0xa1/0xd0 [dvb_usb_cxusb]
> [  103.985296]  [<f8b84737>] cxusb_bluebird_gpio_rw+0x37/0x50
> [dvb_usb_cxusb]
> [  103.985321]  [<f8b852a6>] cxusb_bluebird_gpio_pulse+0x56/0x70
> [dvb_usb_cxusb]
>
> [  103.985347]  [<f8b85443>] dvico_bluebird_xc2028_callback+0x13/0x30
> [dvb_usb_c
> xusb]
> [  103.985363]  [<f8cbc058>] check_firmware+0x288/0x880 [tuner_xc2028]
> [  103.985389]  [<f8b84251>] cxusb_ctrl_msg+0xa1/0xd0 [dvb_usb_cxusb]
> [  103.985440]  [<f8b8449f>] cxusb_i2c_xfer+0x21f/0x3c0 [dvb_usb_cxusb]
> [  103.985463]  [<f8cbc6b6>] generic_set_freq+0x66/0x500 [tuner_xc2028]
> [  103.985495]  [<c01049c7>] common_interrupt+0x23/0x28
> [  103.985526]  [<f89f439f>] i2c_transfer+0x6f/0xa0 [i2c_core]
> [  103.985572]  [<f8cbce64>] xc2028_set_params+0xf4/0x230 [tuner_xc2028]
> [  103.985604]  [<f8b06c95>] zl10353_set_parameters+0x505/0x660 [zl10353]
> [  103.985634]  [<c03610c4>] schedule+0x284/0x520
> [  103.985698]  [<f8b745b1>] dvb_frontend_swzigzag_autotune+0xc1/0x240
> [dvb_core
> ]
> [  103.985769]  [<c01353b0>] process_timeout+0x0/0x10
> [  103.985806]  [<f8b74cd9>] dvb_frontend_swzigzag+0x179/0x270 [dvb_core]
> [  103.985837]  [<f8b755af>] dvb_frontend_thread+0x38f/0x430 [dvb_core]
> [  103.985862]  [<c011d783>] __wake_up_common+0x43/0x70
> [  103.985894]  [<c013fe00>] autoremove_wake_function+0x0/0x50
> [  103.985925]  [<f8b75220>] dvb_frontend_thread+0x0/0x430 [dvb_core]
> [  103.985941]  [<c013faf9>] kthread+0x39/0x70
> [  103.985941]  [<c013fac0>] kthread+0x0/0x70
> [  103.985941]  [<c0104bd3>] kernel_thread_helper+0x7/0x14
> [  103.985941]  =======================
> [  103.985941] Code: ec 10 89 f8 64 8b 35 00 80 4d c0 e8 16 0e 00 00 8d 43
> 08 89
>  04 24 8d 44 24 04 8b 53 0c 89 43 0c 8b 0c 24 89 54 24 08 89 4c 24 04 <89>
> 02 ba
>  ff ff ff ff 89 74 24 0c 89 d0 87 03 83 e8 01 74 5f 87
> [  103.985941] EIP:
> [<c0361a85>]__mutex_lock_interruptible_slowpath+0x35/0xe0 SS:ESP
> 0068:f6783d2c
> [  103.985941] ---[ end trace 9e886fbc373acdcc ]---
>
>



_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux