Re: [PATCH] Fix the unc for the frontends tda10021 and stv0297

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Endriss wrote:
> e9hack wrote:
> > the uncorrected block count is reset on a read request for the tda10021 and stv0297. This 
> > makes the UNC value of the femon plugin useless.
> 
> Why? It does not make sense to accumulate the errors forever, i.e.
> nobody wants to know what happened last year...
> 
> Afaics it is ok to reset the counter after reading it.
> All drivers should behave this way.
> 
> If the femon plugin requires something else it might store the values
> and process them as desired.
> 
> Afaics the femon command line tool has no problems with that.

Argh, I just checked the API 1.0.0. spec:
| FE READ UNCORRECTED BLOCKS
| This ioctl call returns the number of uncorrected blocks detected by the device
| driver during its lifetime. For meaningful measurements, the increment
| in block count during a speci c time interval should be calculated. For this
| command, read-only access to the device is suf cient.
| Note that the counter will wrap to zero after its maximum count has been
| reached

So it seens you are right and the drivers should accumulate the errors
forever. Any opinions?

CU
Oliver

-- 
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
----------------------------------------------------------------

_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux