Re: PATCH Pinnacle 320cx Terratec Cinergy HT USB XE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ok I will redo the patch, right now I don't have the card to check without the reset command, but I will check the weekend. Hans also should check with the Cinergy card...
Just one comment, doing a make checkpatch on dib0700_devices.c does not detect a lot of this coding conventions that are not satisfied on the MT226x code section... Shall I correct all I found? or better just the code I inserted and then the rest in an other patch?

Albert

2008/3/18, Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>:
On Tue, 18 Mar 2008 21:11:52 +0100
"Albert Comerma" <albert.comerma@xxxxxxxxx> wrote:

Hi Albert,

The patch looks sane, but I have a few comments to improve it:

> diff -crB v4l-dvb-orig/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c v4l-cyn/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c

Please, use unified diff format (diff -upr). If you're using the Mercurial
tree, the better is to use "hg diff". It will produce the patch with the proper
format.

> +        712,  // inv_gain

We shouldn't use C99 type of comments. All coments should use the standard C way:
        712, /* inv_gain */

Please use "make checkpatch" [1]. This will produce several warnings about Linux
CodingStyle violations, and you help you to fulfill the current rules, like the
above.

If you have any doubts on how to submit a patch, please read README.patches [2].

[1] If you're patching against v4l-dvb development tree, available at
http://linuxtv.org/hg/v4l-dvb. Otherwise, you'll need to run Kernel
script/checkpatch.pl by hand.

[2] http://linuxtv.org/hg/v4l-dvb/raw-file/tip/README.patches


> +        case XC2028_RESET_CLK:
> +                err("%s: XC2028_RESET_CLK %d\n", __FUNCTION__, arg);
> +                break;

There's no need anymore to implement reset_clk. Please test without it. The
only driver that currently needs this callback is tm6000.

Cheers,

Mauro

_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux