hermann pitton wrote: > Hi, > > quick patches are always fine :) > > Am Sonntag, den 19.08.2007, 19:56 +0200 schrieb bobbens@xxxxxxxxx: >> Hello, >> >> After getting my card working I decided to hack up a patch to get >> autodetection working. With mkrufky's guidance I was able to make a >> patch he had few complaints of which I now include here. > > This suggests somehow that Mike is fine with what you have so far. > I don't believe that. > > We should not add new cards these days just by doing some code > duplication with the first working testing case on saa7134-dvb. > (card=109) > > Also this one should not be in the Philips Tigers eeprom detection IMHO. > > We should know too, if it really has a LNA. The first guess working is > no equivalent for removing the tuner shielding. At least a test with > config=0 should be done. Else we might stay in the dark, when more > assured hardware knowledge is needed in the future. > > Mike please take over/comment. Hermann, I showed him how to make a patch and suggested that he send it in to the mailing list for exactly this reason -- because I am not familiar with all the intricacies of the various saa7134 cards. I had some issues with his original patch, and I gave him some critique. I would not commit the patch for him even then, because I figured that some other eyes might see other issues. Yours, for example. He did not simply duplicate the code -- his card has the tuner on a different i2c address. What do you suggest that he do instead? His card seems to be dvb-t only, he claims no analog support, but I have trouble believing that, given that it uses a tda8275 tuner and a saa7131 bridge -- this bridge has a tda8290 spliced into it. For sure the card must support analog tv, but he says there is no radio input, no svideo input and no composite input. Feel free to make any suggestions, I will not commit any patch if people disagree. Cheers, Mike _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
