On Monday 30 July 2007 18:30:33 Patrick Boettcher wrote: > Dear all, > > Can all of you using a dib0700-based-design with problem please try > the following firmware > > http://www.wi-bw.tfh-wildau.de/~pboettch/home/linux-dvb-firmware/dvb- >usb-dib0700-03-pre1.fw The firmware kills the remote handling code. Once I pressed one remote button I get for each RC_INTERVAL either "dib0700: Unknown remote controller key : 0 0" or "dib0700: Unknown remote controller key : 1 0" alternating with every pressed button. The same driver with dvb-usb-dib0700-01.fw firmware works as expected. Attached is a small patch to kill the unneeded '\n' in the err() macros in the rc_query Signed-off-by: Janne Grunau <janne-dvb@xxxxxxxxx> Janne
diff -r c58cb07fa064 linux/drivers/media/dvb/dvb-usb/dib0700_devices.c --- a/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Mon Jul 30 22:02:17 2007 +0200 +++ b/linux/drivers/media/dvb/dvb-usb/dib0700_devices.c Tue Jul 31 00:15:01 2007 +0200 @@ -274,7 +274,7 @@ static int dib0700_rc_query(struct dvb_u *state = REMOTE_NO_KEY_PRESSED; i=dib0700_ctrl_rd(d,rc_request,2,key,4); if (i<=0) { - err("RC Query Failed\n"); + err("RC Query Failed"); return 0; } if (key[0]==0 && key[1]==0 && key[2]==0 && key[3]==0) return 0; @@ -287,7 +287,7 @@ static int dib0700_rc_query(struct dvb_u return 0; } } - err("Unknown remote controller key : %2X %2X\n",(int)key[2],(int)key[3]); + err("Unknown remote controller key : %2X %2X",(int)key[2],(int)key[3]); } return 0; }
_______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb