Hi, 2007/6/14, P.Nejedly@xxxxxxxxxx <P.Nejedly@xxxxxxxxxx>: > Hi, > > Please find attached the patch that corrects enum usage in tzap code. > The problem is that the code passes enum references as int*, which is not > correct in some cases. There are ABIs for which sizeof(int) != sizeof(enum), > so a function using the pointer for writing to an enum field as int* clobbers > nearby data (other structure members, in this case). > > One example of such an ABI is ARMs EABI and I'm using tzap on one embedded box > based on ARM EABI (Buffalo LinkStation Pro). Original tzap code was not able > to tune (passing e.g. code_rate_HP as invalid FEC_NONE, while channels.conf > contained FEC_2_3), after the patch, it works for me. I applied your patch (some white-space stuff fixed), as nobody else seems to take care of it ... > I didn't inspect othet code too carefully, but it seems that other channels > file parsers in dvb-apps are OK (except czap?). Ok, will have a (quick) look. > Nenik > > Signed-off-by: Petr Nejedly <nenik@xxxxxxxxxxxxxxxxx> Thanks :) Christoph _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
