> I already took the liberty of integrating the fix and pushing it to
> http://linuxtv.org/hg/~aapot/m920x
<http://linuxtv.org/hg/%7Eaapot/m920x> . I actually had a hunch that this
> type of thing might be needed, but didn't believe it was necessary with
> bulk pipes as well.
>
> I have also integrated a patch that might make hw pid filtering work on
> both endpoints. This has not been tested yet on Lifeview TV Walker Twin
> although it seems sensible.
>
> Sorry for the inconvenience. Nice catch in any case!
>
> --
> Aapo Tahkola
Excellent!
BTW, regarding the filtering code. In m920x.c, should the line "if
(adap_enabled[i]) continue;" really be "if (!adap_enabled[i])
continue;"? ie:
--- m920x.c
for (i = 0; i < M9206_MAX_ADAPTERS; i++) {
- if (adap_enabled[i])
+ if (!adap_enabled[i])
continue;
if ((ret = m920x_set_filter(d, 0x81 + i, 0, 0x0)) != 0)
return ret;
if ((ret = m920x_set_filter(d, 0x81 + i, 0, 0x02f5)) != 0)
return ret;
}
---
Also, while you're in the repository fixing things, here is a cosmetic
fix for dvb-usb-init.c to make the correct description appear for the
option 'force_pid_filter_usage':
--- dvb-usb-init.c
int dvb_usb_disable_rc_polling;
module_param_named(disable_rc_polling, dvb_usb_disable_rc_polling, int,
0644);
MODULE_PARM_DESC(disable_rc_polling, "disable remote control polling
(default: 0).");
static int dvb_usb_force_pid_filter_usage;
module_param_named(force_pid_filter_usage,
dvb_usb_force_pid_filter_usage, int, 0444);
-MODULE_PARM_DESC(disable_rc_polling, "force all dvb-usb-devices to use
a PID filter, if any (default: 0).");
+MODULE_PARM_DESC(force_pid_filter_usage, "force all dvb-usb-devices to
use a PID filter, if any (default: 0).");
---
Cheers,
Jeremy
_______________________________________________
linux-dvb mailing list
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
