On Tue, Mar 20, 2007 at 05:03:58PM +0200, Aapo Tahkola wrote: > Nice job! Thanks! > Signed-off-by: Aapo Tahkola <aet@xxxxxxxxxxxxxx> > > Add comments to describe different sticks rc return values. > These might conflict with future hardware. I don't believe that's right. I traced the remote control code with different remote controls and I believe the lifeview and megasky return identical state codes. Certainly when used with the supplied remote control, the lifeview returns codes 0x80, 0x91, 0x92, 0x93 in normal operation. I think the original code in the function was correct in its handling of those codes, except for a bug in the auto-repeat delay, which allowed *state to be returned undefined. When I point other remote controls at the device and stress test the function I get codes 0x88, 0x99, 0xc0, 0xd8, which do not represent a known keypress. The original code emits a kernel message for those codes; my change simply cleans it up to ignore them utterly. It's likely that the state value is actually a bitmap and we don't know what each bit means; it's likely that bit 3 means "framing error" or something similar. Since we don't have a datasheet then we can only test a variety of byte values. Nick. _______________________________________________ linux-dvb mailing list linux-dvb@xxxxxxxxxxx http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
