Re: build system problem with DVB_FE_CUSTOMISE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andrew de Quincey wrote:
> On Monday 31 July 2006 15:37, Andrew de Quincey wrote:
>> On Monday 31 July 2006 12:27, Oliver Endriss wrote:
>>> Andrew de Quincey wrote:
>>>> Hi, there seems to be a build system error with DVB_FE_CUSTOMISE.
>>>>
>>>> When you do "make allmodconfig", you get multiple lines like:
>>>>
>>>> DVB_B2C2_FLEXCOP: Driver is incompatible with  'DVB_FE_CUSTOMISE'
>>>>
>>>> It seems to be (wrongly) thinking the lines like
>>>>         select DVB_STV0299 if !DVB_FE_CUSTOMISE
>>>>
>>>> mean the driver shouldn't be enabled when DVB_FE_CUSTOMISE is on... so
>>>> all DVB drivers end up disabled, 'cos they all have this option.
>>> Imho DVB_FE_CUSTOMISE was a bad idea and should be removed completely.
>>>
>>> It does not hurt if more frontend drivers will be compiled than actually
>>> needed. Keep it simple.
>> I would tend to agree with you, but there was obviously a demand for this
>> feature since the cx88/saa7134 drivers both had their own way of doing
>> exactly this. This way at least means we don't need a zillion #ifdefs
>> cluttering up the card driver code.


If the zillion #ifdef's in there, if it is gone, that itself makes that
code a bit better to read. It was really hard to read, the code in there
without any layout at all with so much clutter.


Manu

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux