Re: idea on how to break the static dependencies on demodulator modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 11, 2006, Trent Piepho wrote:
> On Wed, 10 May 2006, Andrew de Quincey wrote:
> > Hi - updated the http://linuxtv.org/hg/~quincy/v4l-dvb-attach tree with the
> > last round of ideas for this.
> 
> This looks pretty good.

I don't like it.

You know, instead of messing with *all* frontend drivers
and the internals of dvb_unregister_frontend(), I think
it would be much better to:

- add dvb_attach() and dvb_detach() functions
- leave frontend drivers unmodified
- so nothing changes for out-of-tree STB like users like tuxbox
- for selected card drivers where you care to make this change,
  replace foofrontend_attach() by dvb_attach(foofrontend_attach,...)
  and dvb_unregister_frontend() by dvb_detach()

Now the problem is implementing dvb_detach() because
symbol_put_addr() is broken.

The right thing to do is to fix symbol_put_addr(), and not
to kludge around it.

So what you need to do is to keep pushing that the
symbol_put_addr() fix makes it into 2.6.17. Send it
again, this time to Linus (Cc: akpm + Rusty Russel).
Show him that it is important to get his fixed.
Keep sending the patch until the issue is fixed.
(If you want you could also add it to
bugzilla.kernel.org)

(Backwards compat note: for old kernels compat.h
can define dvb_attach() + dvb_detach() to just
call foofrontend_attach() and dvb_unregister_frontend().)


Johannes

_______________________________________________

linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb

[Index of Archives]     [Linux Media]     [Video 4 Linux]     [Asterisk]     [Samba]     [Xorg]     [Xfree86]     [Linux USB]

  Powered by Linux