Andreas Oberritter wrote:
Michael Krufky wrote:
I think that this was a good idea, although the same exact thing could
be done for all of the other drivers, potentially leading to the
creation of many many more modules just for handling pll's ...
It's not just about PLLs, different frontend modules can require
different register settings for symbol rate and other stuff even if they
use the same demod chip.
I like this patch and I think it should be applied. It is a disadvantage
to have all the code and arrays duplicated in several drivers if we
could have it at a single place.
I would much rather see the pll definition moved into dvb-pll, and the
pll_set function altered to use dvb_pll_configure.
The code can still be changed to use dvb-pll afterwards without
unnecessary code duplication.
I can agree to that. The same can be done for lg-h06xf, and many
others. A lot of duplicated code could be removed, and I do agree that
this would be a step forward. The only problem I see with this is that
we'll end up with many tiny little header files just like this one,
bsbe1.h and bsru6.h ... This isn't necessarily a bad thing either. I
just didn't know if this is what we wanted to be doing. Would it make
sense to consolidate these small files into single source.[ch] files?
What do you think?
Regards,
Michael Krufky
_______________________________________________
linux-dvb@xxxxxxxxxxx
http://www.linuxtv.org/cgi-bin/mailman/listinfo/linux-dvb
