On Tue, 17 Jan 2006, Darren Salt wrote: > I demand that J.O. Aho may or may not have written... English ain't my strong side, for me that statment don't make much sense. This is partly the same code I last year posted to the linux-kernel maillist with the modification of using parm to select the remote type. > [snip] >> name = "Hauppauge"; >> ir->get_key = get_key_haup; >> ir_type = IR_TYPE_RC5; >> - ir_codes = ir_codes_rc5_tv; >> + /* We have two options here black or grey remote */ >> + /* J.O. Aho <trizt@xxxxxxxxx> */ >> + if(hauppauge==0) { >> + /* We use black remote */ >> + ir_codes = ir_codes_rc5_tv; >> + } else { >> + /* We use grey remote */ >> + ir_codes = ir_codes_rc5_tv_grey; > > The raw key codes and the comments for that latter mapping happen to exactly > match my Nova-T remote control's keys - which, as I've said elsewhere, are a > subset of the newer (cx88) Nova-T remote control's keys. Didn't know about the nova-t until now, found it after a bit of seaching in the v4l/nova-t-usb2.c and yes, it seems to be quite similar, just 11 more keys on the nova-t remote. > I'd choose ir_codes_hauppauge_new for ths, but that's just me... I'm a bit worried about a thing here, I have seen some pages concerning lirc configuration that does refer the grey/black remote as the old one and on the current photos from hauppauge the remotes shipped nowadays with the PVR cards are grey and has 11 extra keys compared with the older models. I guess we need better names for the hauppauge remotes in general, so that people will have easier to know which is which, specially if all would happen to be using the same driver (don't know anything about the current one) Older grey remote: http://www.kotiaho.net/~trizt/tmpimg/hauppauge-grey.jpg Current grey remote: http://www.hauppauge.com/images/pvr250_w_remote.jpg -- //Aho ------------------------------------------------------------------------ E-Mail: trizt@xxxxxxxxx URL: http://www.kotiaho.net/~trizt/ ICQ: 13696780 System: Linux System (PPC7447/1000 AMD K7A/2000) ------------------------------------------------------------------------ EU forbids you to send spam without my permission ------------------------------------------------------------------------