On Thu, Dec 01, 2005, Steve Toth wrote:
>
> >Anyway, enable/disable_plli2c() should then probably be named
> >i2c_gate_ctrl(..., int enable) or something like that if it
> >doesn't deal with just plls.
> >
> Done. See attached.
>
> [Patch] Adding support for the Hauppauge HVR1100 and HVR1100-LP products
>
> Signed-off-by: Steven Toth <stoth@xxxxxxxxxxxxx>
Looks good.
Acked-by: Johannes Stezenbach <js@xxxxxxxxxxx>
It's up to Mauro or Michael to comment on the cx88 part.
One minor nit:
> --- linux/drivers/media/video/cx88/cx88-i2c.c 16 Oct 2005 12:13:58 -0000 1.33
> +++ linux/drivers/media/video/cx88/cx88-i2c.c 1 Dec 2005 19:54:26 -0000
> @@ -140,7 +140,20 @@ void cx88_call_i2c_clients(struct cx88_c
> {
> if (0 != core->i2c_rc)
> return;
> - i2c_clients_command(&core->i2c_adap, cmd, arg);
> +
> + if (core->dvbdev == NULL) {
> + i2c_clients_command(&core->i2c_adap, cmd, arg);
> + } else {
superflous braces
Johannes
