On Fri, Sep 02, 2005 Edgar Toernig wrote: > below is a patch against the 2.6.13 dvb code to fix some > problems I had with a Pinnacle PCTV-Sat, mainly the fifo > overrun errors. > > I've added some error recovery that works often but is > pretty noisy. The best result is to simply not enable > those status interrupts. Due to resyncs added to the > risc-code the dma-controller seems to always recover > from fifo overruns. To get all status irqs back one has > to set bt878_debug now. > > Further, I've added a sleep function which turns off the > IF-relay. So now it's possible to connect another receiver > to the IF-out connector and when the card is not used (for > 5 seconds) the external box gets the antenna. > > The new relay handling also fixes a problem when trying to > use analog video-in and dvb at the same time. Formerly, > at the moment you open the video dev the relay was turn > off and the frontend got no signal any more. That works > correct now - you can watch digital and analog tv at the > same time. > > And then there are a couple of cleanups - code, comments, > whitespaces, error checks, log levels, ... > > Comments welcome ... It is unadvisable to mix cleanups and other changes in one patch. Ideally you would send multiple small patches, one for each logically seperate change, e.g.: - fifo overrun error recovery - IF-relay stuff - formatting / whitespace changes - other cleanups Yes, I realize how much work it is to split a patch this way. BTW, have you looked at linux/Documentation/SubmittingPatches? (Signed-off-by etc.) > PS: Do I have to sends the couple of lines that touch the > bttv driver to the bttv-maintainer or is anyone collecting > dvb-related bttv patches and forwards them? If the changes depend on each other it doesn't make sense to split the patch this way. Just send it to both linux-dvb and video4linux-list and see who'll pick it up. Thanks, Johannes
