On Wed, Aug 03, 2005 at 08:06:41PM +0100, David Johnson wrote: > On Wednesday 03 August 2005 19:43, David Johnson wrote: > > This patch adds support for Nebula DigiTV PCI cards with the MT352 > > frontend. > > > > Signed-off-by: David Johnson <dj@xxxxxxxxxxxxxxx> > > > > This fixes the whitespace, indentation and extra brace issues present in my > > last patch. > > To be applied after my "Clean-up dvb-bt8xx.c" patch. I comitted this one, too. Just one comment: > + /* > + * It is possible to determine the correct frontend using the I2C bus (see the Nebula SDK); > + * this would be a cleaner solution than trying each frontend in turn. > + */ IMHO this isn't cleaner. You would move (or, worse, copy) the frontend-specific probing code from the frontend driver to the card driver. In the long run this is a maintenance nightmare. Thanks, Johannes
