Johannes Stezenbach wrote: >Michael Krufky wrote: > > >>The attached patch has been revised to correct the sync byte for MPEG-2 >>transport stream packets. Detailed changelog is included in the header >>of the patch. >> >> >... > > >>- Let Kconfig decide whether to include frontend-specific code in cx88-dvb. >> >> linux/drivers/media/dvb/frontends/dvb-pll.c | 13 ++++ >> linux/drivers/media/dvb/frontends/dvb-pll.h | 1 >> linux/drivers/media/video/cx88/cx88-cards.c | 3 - >> linux/drivers/media/video/cx88/cx88-dvb.c | 57 ++++++++++++++------ >> linux/drivers/media/video/cx88/cx88-mpeg.c | 8 +- >> >> > >Besides that the patch lacks the Kconfig changes which >would make the #ifdef mess useful, I still advise >against it. It is just not userfriendly if you require >users to find out what frontend driver the need for their card. >We had that in the past, and I think most people like >the current approach better. > Johannes- The correct lines are ALREADY in kconfig: +config DVB_LGDT3302 ... and the same for OR51132, CX22702, MT352, etc... All this really does is rename the "HAVE_LGDT3302" to "CONFIG_DVB_LGDT3302" -- In the past, the symbol was sitting there doing nothing, NOW it actually means something. This doesn't affect any of the boards in the linuxtv tree... It only affects the boards in the v4l tree. In addition, the makefile in video4linux cvs automatically selects every frontend to be built. Do you still think it's a bad idea? I think that it is the correct way to do things. I don't think we need to assume that a user doesn't know anything. If a user is going to recompile his/her kernel, they need to know what chips to give support to. Default kernels should have all options selected as modules, so IMHO, this shouldn't cause problems for too many people. We are trying to reduce the dependency of v4l on dvb. If you still cannot agree to this, then I can add the following to the top of cx88-dvb (to restore old behavior of blindly including every frontend), but I would rather not: +#define CONFIG_DVB_CX22702 1 +#define CONFIG_DVB_OR51132 1 +#define CONFIG_DVB_LGDT3302 1 +#define CONFIG_DVB_MT352 1 Basically, all i effectively did is remove those four lines and renamed the symbols to make sense. What do you think? -- Michael Krufky
