Mac Michaels wrote:
>I do not approve this patch. Mac Michaels
>
>--- linux-2.6.13/drivers/media/video/cx88/cx88-mpeg.c 2005-07-05 00:34:56.000000000 +0000
>+++ linux/drivers/media/video/cx88/cx88-mpeg.c 2005-07-05 00:47:22.000000000 +0000
>@@ -73,11 +73,11 @@
> cx_write(TS_GEN_CNTRL, 0x0040 | dev->ts_gen_cntrl);
> udelay(100);
> cx_write(MO_PINMUX_IO, 0x00);
>- if (core->board == CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_Q) {
>[1]- cx_write(TS_HW_SOP_CNTRL,0x47<<16 | 188<<4 | 0x00);
>[2]+ cx_write(TS_HW_SOP_CNTRL,47<<16|188<<4|0x00);
>+ if ((core->board == CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_Q) ||
>+ (core->board == CX88_BOARD_DVICO_FUSIONHDTV_3_GOLD_T)) {
> cx_write(TS_SOP_STAT, 0<<16 | 0<<14 | 1<<13 | 0<<12);
> } else {
>[3]- cx_write(TS_HW_SOP_CNTRL,47<<16|188<<4|0x00);
> cx_write(TS_SOP_STAT,0x00);
> }
> cx_write(TS_GEN_CNTRL, dev->ts_gen_cntrl);
>
>I added numbers in braces for reference in the following discussion.
>It appears that Michael thought lines [1] and [3] were identical.
>He simplified the code by combining them in one place at line [2].
>Look carefully at the hexadecimal 0x47 constant in the middle of line [1]
>It the value required for FusionHDTV 3 Gold cards. Lines [2] and [3]
>contain the decimal 47 constant. This part of the patch should not
>be applied.
>
>As an aside, I wonder if all cards should use the 0x47 constant as it is
>listed as the default start byte value for ATSC. It is not actually transmitted
>but is generated by the LGDT3302 chip. I guess other chips could use
>a different value if they want to. That is why I chose not to change the
>code for cards other than FusionHDTV 3 Gold.
>
>
Mac-
The change above is already in video4linux cvs. Please test from cvs to
confirm that it should be reverted. I was talking to Mauro about this
and we were both wondering why you had changed from decimal 47 to Hex
0x47 , where it seems that decimal 47 should be correct based on all
other calls... I have tried both values on my board and noticed no
difference. If this actually causes a problem for you, I will revert
this change. I am not sending this to Andrew Morton or LKML until this
is all resolved :-)
Let me know.
--
Michael Krufky
