Hi Gavin, Gavin Hamill wrote: > Sorry, meant to include [PATCH] in the original posts: > > http://linuxtv.org/pipermail/linux-dvb/2005-June/002848.html > > The patch works fine, was happily zapping channels with VDR last night using > this [1] device. There are a few very minor nits. Could you please clean them up and resubmit the patch with a Signed-off-by: line? (see dvb-kernel/SubmittingPatches) > +static int alps_tdbe2_pll_set(struct dvb_frontend* fe, struct dvb_frontend_parameters* params) > +{ > + struct ttusb* ttusb = (struct ttusb*) fe->dvb->priv; > + u32 div; > + u8 data[4]; > + struct i2c_msg msg = { .addr = 0x62, .flags = 0, .buf = data, .len = sizeof(data) }; > + > + div = (params->frequency + 35937500 + 31250) / 62500; > + > + data[0] = (div >> 8) & 0x7f; > + data[1] = div & 0xff; > + data[2] = 0x85 | ((div >> 10) & 0x60); > + data[3] = (params->frequency < 174000000 ? 0x88 : params->frequency < 470000000 ? 0x84 : 0x81); indentation is one tab, not spaces > + > + if (i2c_transfer (&ttusb->i2c_adap, &msg, 1) != 1) return -EIO; make that two lines And please add the "select DVB_VES1820" in Kconfig that Anssi Hannula mentioned. Thanks, Johannes
