On Wednesday 15 June 2005 08:07 pm, Michael Krufky wrote: > Mac Michaels wrote: > >This patch was sent to both v4l2 and dvb lists because > > it affects files in both video and dvb media > > subdirectories. If it needs to be made against some > > other source tree, please tell me how to get that > > source tree. > > Mac- > > It took me over an hour to patch this code against > video4linux cvs (while eating chinese food and being > bombarded by instant-messages). Well that was a waste of my time. I was originally making patches against the video4linux CVS. Based on some of the responses to my post of my first patch I thought I was not supposed to make patches for video4linux CVS because this is a dvb driver. So I got the mm kernel and merged everything into that at the proper locations to create the patch I started this thread with. I also worked out the Kconfig stuff so that you could select the driver with a kernel configuration program. While doing this I discovered the nasty little secret that makes it impossible to create a cx88-dvb that is configured for only one of the dvb drivers. > I made a few minor changes to it, in order to fit in with > the rest of the code in cvs. Please patch this against > current video4linux cvs yourself and tell me if it still > works correctly for you. I'll do that tomorrow. > After you tell me that it > works, I'd like to adapt this to include support for my > DViCO FusionHDTV3 Gold-T card (card #28), which uses a > Thomson DDT 7611 tuner, as opposed to your card (#17) > which uses the microtune tuner. I'll take a swipe at that tomorrow just for the heck of it. > There currently is some dvb code in video4linux cvs, > which will eventually be moved into the DVB cvs. I don't > know what is involved in this, but I'd like to commit > this to cvs before that move is made, this way all of the > DVB code can me moved together. That is what I tried to do for my driver with the original patch I sent on this thread. I made changes to files in both the video and dvb subdirectories. > ALSO, if you plan on sending in more patches, this is how > you should do it: > > - Patches should be against current video4linux cvs, in > patch -p1 form. > > Here is how I make my patches (this isn't necessarily the > ONLY way, but I find it to be easiest.) > > cvs -d > :pserver:anonymous@xxxxxxxxxxxxxxx:/cvs/video4linux login > cvs -d > :pserver:anonymous@xxxxxxxxxxxxxxx:/cvs/video4linux co > video4linux > > cp video4linux video4linux.orig -r > > cd video4linux > (make your changes within the video4linux directory) > cd .. > > diff -upN video4linux.orig video4linux > > name_of_your_patch.patch > > Then, edit the patchfile in nano or emacs or whatever > editor you like, and remove the lines saying "Common > subdirectories: yadda yadda yadda" How about just checking out the files from cvs and making my changes. Change to the video4linux directory. Then produce a patch with something like this: cvs diff -upPN The above may not be exactly right, but I'll experiment a bit and get it to work. > If you follow the guidelines above, people will be more > likely to try out your patch, because they will be able > to apply it cleanly against video4linux cvs by doing the > following: (assuming that the patchfile and video4linux > source are both located in /usr/src) > > cd /usr/src/video4linux > patch -p1 < ../name_of_your_patch.patch > > And remember, if you cant get your patch to apply, nobody > else will either. Good point. I tend to forget to verify that the patch applies properly. > Once again, I greatly thank you for your time spent on > the LGDT3302 driver ... I truly cannot wait untill I can > get this code working with my board. I just need the driver for my own card. I am glad to share it. -- Mac
