Hello I've noticed some small pb in bt878c: - bt878_debug static variable is not initialized - parm desc of 'verbose' parm is wrong (mentions 'bt878_verbose' param name instead of plain 'verbose') - likewise for debug parameter - the description of debug param can be misleading: user might be tempted to set debug=on instead of debug=1 Here's a very small patch to fix these issues. HTH Index: bt878.c =================================================================== RCS file: /cvs/linuxtv/dvb-kernel/linux/drivers/media/dvb/bt8xx/bt878.c,v retrieving revision 1.25 diff -u -p -r1.25 bt878.c --- bt878.c 4 Apr 2005 18:08:16 -0000 1.25 +++ bt878.c 14 Apr 2005 14:22:19 -0000 @@ -52,13 +52,13 @@ /**************************************/ static unsigned int bt878_verbose = 1; -static unsigned int bt878_debug; +static unsigned int bt878_debug = 0 ; module_param_named(verbose, bt878_verbose, int, 0444); -MODULE_PARM_DESC(bt878_verbose, +MODULE_PARM_DESC(verbose, "verbose startup messages, default is 1 (yes)"); module_param_named(debug, bt878_debug, int, 0644); -MODULE_PARM_DESC(bt878_debug, "Turn on/off debugging (default:off)."); +MODULE_PARM_DESC(debug, "Turn on/off debugging, default is 0 (off)."); int bt878_num; struct bt878 bt878[BT878_MAX];
