On Thu, Jun 01, 2017 at 07:21:22AM +0000, ? ? wrote: > From: Pan Li <incarnation.p.lee@xxxxxxxxxxx> > > Convert type le16 to cpu for consistent type assignment. > > Signed-off-by: Pan Li <incarnation.p.lee@xxxxxxxxxxx> > --- > drivers/staging/typec/tcpci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/typec/tcpci.c b/drivers/staging/typec/tcpci.c > index 405c9cc..18d2e06 100644 > --- a/drivers/staging/typec/tcpci.c > +++ b/drivers/staging/typec/tcpci.c > @@ -292,7 +292,7 @@ static int tcpci_pd_transmit(struct tcpc_dev *tcpc, > if (ret < 0) > return ret; > > - header = msg ? msg->header : 0; > + header = msg ? le16_to_cpu(msg->header) : 0; > ret = tcpci_write16(tcpci, TCPC_TX_HDR, header); This looks like it introduces bugs. We normally write endian data and you've changed it to write CPU endian data. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
