On Tue, May 23, 2017 at 10:38 PM, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, May 23, 2017 at 09:32:13PM +0200, Raphaël Beamonte wrote: >> drivers/staging/lustre/lustre/llite/xattr.c:89:62: warning: Variable >> length array is used. >> drivers/staging/lustre/lustre/llite/xattr.c:366:62: warning: Variable >> length array is used. >> + fullname = kmalloc(strlen(handler->prefix) + strlen(name) + 1, >> + GFP_KERNEL); >> + if (!fullname) >> + return -ENOMEM; >> + >> sprintf(fullname, "%s%s\n", handler->prefix, name); >> rc = md_setxattr(sbi->ll_md_exp, ll_inode2fid(inode), >> valid, fullname, pv, size, 0, flags, >> ll_i2suppgid(inode), &req); >> + >> + kfree(fullname); > > Didn't we reject much this same patch last week? ...besides the fact that kasprintf(); might be better in cases when malloc + snprintf is used. -- With Best Regards, Andy Shevchenko _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
