Re: [PATCH] staging: lustre: lnet: specify address space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 16, 2017 at 10:56:10PM +0200, Paolo Cretaro wrote:
> Fix warning issued by sparse:
> incorrect type in assignment (different address spaces).
> 
> Signed-off-by: Paolo Cretaro <melko@xxxxxxxxxxxxxx>
> ---
>  drivers/staging/lustre/lnet/lnet/lib-socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/lustre/lnet/lnet/lib-socket.c b/drivers/staging/lustre/lnet/lnet/lib-socket.c
> index 9fca8d225ee0..e5e5213b4da0 100644
> --- a/drivers/staging/lustre/lnet/lnet/lib-socket.c
> +++ b/drivers/staging/lustre/lnet/lnet/lib-socket.c
> @@ -181,7 +181,7 @@ lnet_ipif_enumerate(char ***namesp)
>  			goto out0;
>  		}
>  
> -		ifc.ifc_buf = (char *)ifr;
> +		ifc.ifc_buf = (char __user *)ifr;

But it's not a __user pointer so this is wrong.  You have deleted a
valuable warning message which is there to inform us about important
bugs.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux