On Tue, May 16, 2017 at 01:19:10PM +0100, Okash Khawaja wrote: > Hi, > > On Tue, May 16, 2017 at 1:00 PM, Greg Kroah-Hartman > <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Mon, May 15, 2017 at 06:45:37PM +0100, Okash Khawaja wrote: > >> This patch fixes the issue where TTY-migrated synths would take a while to shut up after hitting numpad enter key. When calling synth_flush, even though XOFF character is sent as high priority, data buffered in TTY layer is still sent to the synth. This patch flushes that buffered data when synth_flush is called. > > > > Minor nit, please line-wrap your changelog text at 72 columns so that I > > don't have to do it "by hand". > Sure, will do. > > > > >> > >> It also tries to ensure that hardware flow control is enabled, by setting CRTSCTS using tty's termios. > >> > >> Reported-by: John Covici <covici@xxxxxxxxxxxxxx> > >> Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx> > >> Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx> > >> > >> Index: linux-staging/drivers/staging/speakup/serialio.c > >> =================================================================== > > > > Are you using git? These lines are odd... > They come from quilt. Haven't checked yet if there is an option to > turn them off. There is, here's what is in my .quiltrc: QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab" QUILT_DIFF_ARGS="--no-timestamps --no-index --sort --color=auto -p ab" QUILT_DIFF_OPTS="-p" That will give you the diffstat in the patch as well, which is always helpful to reviewers. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
