Re: [PATCH 09/13] staging: most: net: prefer __func__ over the function name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 12, 2017 at 12:59:57PM +0200, Christian Gromm wrote:
> From: Andrey Shvetsov <andrey.shvetsov@xxxxxx>
> 
> This replaces the function names in the print messages with the __func__
> macro.
> 
> Signed-off-by: Andrey Shvetsov <andrey.shvetsov@xxxxxx>
> Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> ---
>  drivers/staging/most/aim-network/networking.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/most/aim-network/networking.c b/drivers/staging/most/aim-network/networking.c
> index e2935cc..36483b9 100644
> --- a/drivers/staging/most/aim-network/networking.c
> +++ b/drivers/staging/most/aim-network/networking.c
> @@ -502,14 +502,14 @@ static int aim_rx_data(struct mbo *mbo)
>  
>  static int __init most_net_init(void)
>  {
> -	pr_info("most_net_init()\n");
> +	pr_info("%s()\n", __func__);
>  	spin_lock_init(&list_lock);
>  	return most_register_aim(&aim);
>  }
>  
>  static void __exit most_net_exit(void)
>  {
> -	pr_info("most_net_exit()\n");
> +	pr_info("%s()\n", __func__);

No, these need to just be deleted entirely, no need to be noisy for no
good reason at all.  If you really need to trace the code, use the
built-in kernel tracing functionality.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux