Re: [PATCH v3 2/3] staging: typec: fusb302: reset i2c_busy state in error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Rui. LGTM.

On Fri, May 12, 2017 at 1:16 PM, Rui Miguel Silva <rmfrfs@xxxxxxxxx> wrote:
> Fix reset of i2c_busy flag if an error occurs during the i2c block read.
>
> Signed-off-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>
acked-by: Yueyao Zhu <yueyao.zhu@xxxxxxxxx>

> ---
>  drivers/staging/typec/fusb302/fusb302.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index 65df6407db84..37fd0bd0f2a6 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -365,13 +365,15 @@ static int fusb302_i2c_block_read(struct fusb302_chip *chip, u8 address,
>         if (ret < 0) {
>                 fusb302_log(chip, "cannot block read 0x%02x, len=%d, ret=%d",
>                             address, length, ret);
> -               return ret;
> +               goto done;
>         }
>         if (ret != length) {
>                 fusb302_log(chip, "only read %d/%d bytes from 0x%02x",
>                             ret, length, address);
> -               return -EIO;
> +               ret = -EIO;
>         }
> +
> +done:
>         atomic_set(&chip->i2c_busy, 0);
>
>         return ret;
> --
> 2.12.2
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux