On Wed, May 10, 2017 at 12:20 PM, Ian Chard <ian@xxxxxxxxx> wrote:
> An early error handler in send_request() tries to release a spinlock,
> but the lock isn't acquired until the loop below it is entered.
>
> Signed-off-by: Ian Chard <ian@xxxxxxxxx>
> ---
> drivers/staging/ccree/ssi_request_mgr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/ccree/ssi_request_mgr.c b/drivers/staging/ccree/ssi_request_mgr.c
> index 522bd62c102e..8611adf3bb2e 100644
> --- a/drivers/staging/ccree/ssi_request_mgr.c
> +++ b/drivers/staging/ccree/ssi_request_mgr.c
> @@ -376,7 +376,6 @@ int send_request(
> rc = ssi_power_mgr_runtime_get(&drvdata->plat_dev->dev);
> if (rc != 0) {
> SSI_LOG_ERR("ssi_power_mgr_runtime_get returned %x\n",rc);
> - spin_unlock_bh(&req_mgr_h->hw_lock);
> return rc;
> }
> #endif
> --
> 2.11.0
>
Nice catch.
Acked-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxx>
Thanks,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
