Re: staging: fix macros with multiple statements in rtl8723bs/core/rtw_security.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 4 May 2017 11:57:48 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> Read the first couple paragraphs of
> Documentation/process/email-clients.rst for how to send patches.
> 
> > @@ -2236,10 +2248,12 @@ static void rijndaelEncrypt(u32 rk[/*44*/],
> > u8 pt[16], u8 ct[16]) s3 = GETU32(pt + 12) ^ rk[3];
> >  
> >  #define ROUND(i, d, s) \
> > -d##0 = TE0(s##0) ^ TE1(s##1) ^ TE2(s##2) ^ TE3(s##3) ^ rk[4 * i]; \
> > -d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^ rk[4 * i +
> > 1]; \ -d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^ rk[4
> > * i + 2]; \ -d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^
> > rk[4 * i + 3] +do {	\
> > +	d##0 = TE0(s##0) ^ TE1(s##1) ^ TE2(s##2) ^ TE3(s##3) ^
> > rk[4 * i]; \
> > +	d##1 = TE0(s##1) ^ TE1(s##2) ^ TE2(s##3) ^ TE3(s##0) ^
> > rk[4 * i + 1]; \
> > +	d##2 = TE0(s##2) ^ TE1(s##3) ^ TE2(s##0) ^ TE3(s##1) ^
> > rk[4 * i + 2]; \
> > +	d##3 = TE0(s##3) ^ TE1(s##0) ^ TE2(s##1) ^ TE3(s##2) ^
> > rk[4 * i + 3] \ +} while (0)  
> 
> Does this compile?
> 
> regards,
> dan carpenter
> 

Thank you for your replay, I'll do some change.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux