On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote: > On Mon, 1 May 2017 19:59:44 +1000 > "Tobin C. Harding" <me@xxxxxxxx> wrote: > > > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > > > Sparse spits out a warnings about __le16 and unsigned short > > > assignment. Change the type of size and event members of struct > > > hostif_hdr to __le16 and correct conversion to the proper cpu type. > > > > > > Signed-off-by: Cezary Gapinski <gapalinux@xxxxxxxxx> > > > > After discussion on kernelnewbies mailing list and thinking about this > > for a couple of days I am now of the opinion that this patch is > > merge-able. I am probably not fully qualified to say so but no one > > else appears to be super active on this driver. If I am wrong, I'll be > > here to fix it up :) > > > > Reviewed-by: Tobin C. Harding <me@xxxxxxxx> > > > > Good work Cezsary, apologies for the wish-washy replies. I'm learning > > also ;) > > > > Good luck, > > Tobin. > > Hi Tobin, > > nice to know that you also thinking about this fixes. I think that is > just a first step because I noticed much more warning with > big/little-endian issues and perhaps no one else want to touch this. I did up a patch set yesterday that fixes most of the Sparse warnings. It was simply a matter of changing all struct members in ks_hostif.h to be __leXX and adding a few cpu_to_leXX()/leXX_to_cpu() calls. Exactly as you did. I'm going to wait for your patch, and another that is in flight on ks7010, to be merged before I submit it. There will still be a few Sparse warnings that are a little more tricky, so there is still some fun to be had. > I'm also here to help if it is something will be incorrect ;)." Cool > Sorry for my previous messages. Sometimes I forget about crtl+s will > sending my e-mails, so if you received other messages just ignore it. Didn't receive any extra messages :) Cheers, Tobin. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
