On 01/05/17 00:16, Quentin Swain wrote: > Convert S_IRUGO and S_IWUSR macros to octal permissions to resolve > warnings reported by checkpatch.pl > > Signed-off-by: Quentin Swain <dudebrobro179@xxxxxxxxx> Applied > --- > drivers/staging/iio/meter/ade7753.c | 46 ++++++++++++++++++------------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c > index b71fbd3..c0f258c 100644 > --- a/drivers/staging/iio/meter/ade7753.c > +++ b/drivers/staging/iio/meter/ade7753.c > @@ -298,92 +298,92 @@ static IIO_DEV_ATTR_AENERGY(ade7753_read_24bit, ADE7753_AENERGY); > static IIO_DEV_ATTR_LAENERGY(ade7753_read_24bit, ADE7753_LAENERGY); > static IIO_DEV_ATTR_VAENERGY(ade7753_read_24bit, ADE7753_VAENERGY); > static IIO_DEV_ATTR_LVAENERGY(ade7753_read_24bit, ADE7753_LVAENERGY); > -static IIO_DEV_ATTR_CFDEN(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_CFDEN(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_CFDEN); > -static IIO_DEV_ATTR_CFNUM(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_CFNUM(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_CFNUM); > static IIO_DEV_ATTR_CHKSUM(ade7753_read_8bit, ADE7753_CHKSUM); > -static IIO_DEV_ATTR_PHCAL(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_PHCAL(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_PHCAL); > -static IIO_DEV_ATTR_APOS(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_APOS(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_APOS); > -static IIO_DEV_ATTR_SAGCYC(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_SAGCYC(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_SAGCYC); > -static IIO_DEV_ATTR_SAGLVL(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_SAGLVL(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_SAGLVL); > -static IIO_DEV_ATTR_LINECYC(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_LINECYC(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_LINECYC); > -static IIO_DEV_ATTR_WDIV(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_WDIV(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_WDIV); > -static IIO_DEV_ATTR_IRMS(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_IRMS(0644, > ade7753_read_24bit, > NULL, > ADE7753_IRMS); > -static IIO_DEV_ATTR_VRMS(S_IRUGO, > +static IIO_DEV_ATTR_VRMS(0444, > ade7753_read_24bit, > NULL, > ADE7753_VRMS); > -static IIO_DEV_ATTR_IRMSOS(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_IRMSOS(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_IRMSOS); > -static IIO_DEV_ATTR_VRMSOS(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_VRMSOS(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_VRMSOS); > -static IIO_DEV_ATTR_WGAIN(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_WGAIN(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_WGAIN); > -static IIO_DEV_ATTR_VAGAIN(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_VAGAIN(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_VAGAIN); > -static IIO_DEV_ATTR_PGA_GAIN(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_PGA_GAIN(0644, > ade7753_read_16bit, > ade7753_write_16bit, > ADE7753_GAIN); > -static IIO_DEV_ATTR_IPKLVL(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_IPKLVL(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_IPKLVL); > -static IIO_DEV_ATTR_VPKLVL(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_VPKLVL(0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_VPKLVL); > -static IIO_DEV_ATTR_IPEAK(S_IRUGO, > +static IIO_DEV_ATTR_IPEAK(0444, > ade7753_read_24bit, > NULL, > ADE7753_IPEAK); > -static IIO_DEV_ATTR_VPEAK(S_IRUGO, > +static IIO_DEV_ATTR_VPEAK(0444, > ade7753_read_24bit, > NULL, > ADE7753_VPEAK); > -static IIO_DEV_ATTR_VPERIOD(S_IRUGO, > +static IIO_DEV_ATTR_VPERIOD(0444, > ade7753_read_16bit, > NULL, > ADE7753_PERIOD); > -static IIO_DEV_ATTR_CH_OFF(1, S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_CH_OFF(1, 0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_CH1OS); > -static IIO_DEV_ATTR_CH_OFF(2, S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_CH_OFF(2, 0644, > ade7753_read_8bit, > ade7753_write_8bit, > ADE7753_CH2OS); > @@ -514,7 +514,7 @@ static IIO_DEV_ATTR_TEMP_RAW(ade7753_read_8bit); > static IIO_CONST_ATTR(in_temp_offset, "-25 C"); > static IIO_CONST_ATTR(in_temp_scale, "0.67 C"); > > -static IIO_DEV_ATTR_SAMP_FREQ(S_IWUSR | S_IRUGO, > +static IIO_DEV_ATTR_SAMP_FREQ(0644, > ade7753_read_frequency, > ade7753_write_frequency); > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
