On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase struct field names with underscores to comply
> with the standard kernel coding style.
> Changed:
> - FhParms_t
> - DsParms_t
> - CfParms_t
> - IbssParms_t
> - ErpParams_t
>
> Signed-off-by: Janusz Lisiecki <janusz.lisiecki@xxxxxxxxx>
> ---
> drivers/staging/ks7010/ks_hostif.h | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/ks_hostif.h
> index ba0bd92..769dbe8 100644
> --- a/drivers/staging/ks7010/ks_hostif.h
> +++ b/drivers/staging/ks7010/ks_hostif.h
> @@ -239,25 +239,25 @@ struct rate_set8_t {
> u8 rate_pad;
> } __packed;
>
> -struct FhParms_t {
> +struct fh_parms_t {
> u16 dwell_time;
> u8 hop_set;
> u8 hop_pattern;
> u8 hop_index;
> } __packed;
>
> -struct DsParms_t {
> +struct ds_parms_t {
> u8 channel;
> } __packed;
>
> -struct CfParms_t {
> +struct cf_parms_t {
> u8 count;
> u8 period;
> u16 maxDuration;
> u16 durRemaining;
> } __packed;
>
> -struct IbssParms_t {
> +struct ibss_parms_t {
> u16 atimWindow;
> } __packed;
>
> @@ -267,7 +267,7 @@ struct rsn_t {
> u8 body[RSN_BODY_SIZE];
> } __packed;
>
> -struct ErpParams_t {
> +struct erp_params_t {
> u8 erp_info;
> } __packed;
>
> @@ -313,11 +313,11 @@ struct link_ap_info_t {
> u16 beacon_period; /* +10 */
> u16 capability; /* +12 */
> struct rate_set8_t rate_set; /* +14 */
> - struct FhParms_t fh_parameter; /* +24 */
> - struct DsParms_t ds_parameter; /* +29 */
> - struct CfParms_t cf_parameter; /* +30 */
> - struct IbssParms_t ibss_parameter; /* +36 */
> - struct ErpParams_t erp_parameter; /* +38 */
> + struct fh_parms_t fh_parameter; /* +24 */
> + struct ds_parms_t ds_parameter; /* +29 */
> + struct cf_parms_t cf_parameter; /* +30 */
> + struct ibss_parms_t ibss_parameter; /* +36 */
> + struct erp_params_t erp_parameter; /* +38 */
4 out of 5 of these struct members appear to be unused in the
driver. I think the patch is good as it is though because I don't
think we should be chopping up struct descriptions until we are
testing on hardware.
Only my opinion, based more on a hunch than on any real experience.
thanks,
Tobin.
> u8 pad1; /* +39 */
> struct rate_set8_t ext_rate_set; /* +40 */
> u8 DTIM_period; /* +50 */
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
