As far as I can see, the only code that can be executed in line 621 - 635
is ret = rtw_resume_process(padapter);. Perhaps it can be simplified.
julia
---------- Forwarded message ----------
Date: Fri, 28 Apr 2017 22:13:26 +0800
From: kbuild test robot <fengguang.wu@xxxxxxxxx>
To: kbuild@xxxxxx
Cc: Julia Lawall <julia.lawall@xxxxxxx>
Subject: [staging:staging-testing 751/981]
drivers/staging/rtl8723bs/os_dep/sdio_intf.c:627:2-4: WARNING: possible
condition with no effect (if == else)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing
head: 7ecb36442d12f197310a336a0e963badd238f35e
commit: 554c0a3abf216c991c5ebddcdb2c08689ecd290b [751/981] staging: Add rtl8723bs sdio wifi driver
:::::: branch date: 4 hours ago
:::::: commit date: 3 weeks ago
>> drivers/staging/rtl8723bs/os_dep/sdio_intf.c:627:2-4: WARNING: possible condition with no effect (if == else)
git remote add staging https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 554c0a3abf216c991c5ebddcdb2c08689ecd290b
vim +627 drivers/staging/rtl8723bs/os_dep/sdio_intf.c
554c0a3a Hans de Goede 2017-03-29 611 struct pwrctrl_priv *pwrpriv = dvobj_to_pwrctl(psdpriv);
554c0a3a Hans de Goede 2017-03-29 612 struct adapter *padapter = psdpriv->if1;
554c0a3a Hans de Goede 2017-03-29 613 struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
554c0a3a Hans de Goede 2017-03-29 614 int ret = 0;
554c0a3a Hans de Goede 2017-03-29 615 struct debug_priv *pdbgpriv = &psdpriv->drv_dbg;
554c0a3a Hans de Goede 2017-03-29 616
554c0a3a Hans de Goede 2017-03-29 617 DBG_871X("==> %s (%s:%d)\n", __func__, current->comm, current->pid);
554c0a3a Hans de Goede 2017-03-29 618
554c0a3a Hans de Goede 2017-03-29 619 pdbgpriv->dbg_resume_cnt++;
554c0a3a Hans de Goede 2017-03-29 620
554c0a3a Hans de Goede 2017-03-29 621 if (pwrpriv->bInternalAutoSuspend)
554c0a3a Hans de Goede 2017-03-29 622 {
554c0a3a Hans de Goede 2017-03-29 623 ret = rtw_resume_process(padapter);
554c0a3a Hans de Goede 2017-03-29 624 }
554c0a3a Hans de Goede 2017-03-29 625 else
554c0a3a Hans de Goede 2017-03-29 626 {
554c0a3a Hans de Goede 2017-03-29 @627 if (pwrpriv->wowlan_mode || pwrpriv->wowlan_ap_mode)
554c0a3a Hans de Goede 2017-03-29 628 {
554c0a3a Hans de Goede 2017-03-29 629 ret = rtw_resume_process(padapter);
554c0a3a Hans de Goede 2017-03-29 630 }
554c0a3a Hans de Goede 2017-03-29 631 else
554c0a3a Hans de Goede 2017-03-29 632 {
554c0a3a Hans de Goede 2017-03-29 633 ret = rtw_resume_process(padapter);
554c0a3a Hans de Goede 2017-03-29 634 }
554c0a3a Hans de Goede 2017-03-29 635 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
