Re: [PATCH v2] Staging: ks7010: style fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 26, 2017 at 08:37:56PM +1000, Tobin C. Harding wrote:
> On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> > Fix the style of block comments.
> > Move trailing */ to a separate line.
> > Checkpatch was showing:
> > WARNING: Block comments use a trailing */ on a separate line.
> 
> You are doing well Ilia. A few nitpicks
> 
> - Your first subject was better (excluding the filname) :) it was more
>   descriptive.

Yeah.   This subject is bad.

> 
> - staging has a small 's'. You can verify with;
>   $ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c 

Nah..  It can go either way.  No one cares.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux