Driver uses non-uniform file names. Both in respect to itself and in respect to other SDIO drivers. If we name files in a similar fashion to in-tree SDIO drivers then we are following the principle of least surprise. Looking at in-tree SDIO drivers, hif.c would be the file name of choice for the host interface code, however, the driver uses the abbreviation 'hostif' for host interface. Best to be uniform within the driver. Rename ks_hostif.c to hostif.c Rename ks_hostif.h to hostif.h Signed-off-by: Tobin C. Harding <me@xxxxxxxx> --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/{ks_hostif.c => hostif.c} | 2 +- drivers/staging/ks7010/{ks_hostif.h => hostif.h} | 0 drivers/staging/ks7010/ks7010_sdio.c | 2 +- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename drivers/staging/ks7010/{ks_hostif.c => hostif.c} (99%) rename drivers/staging/ks7010/{ks_hostif.h => hostif.h} (100%) diff --git a/drivers/staging/ks7010/Makefile b/drivers/staging/ks7010/Makefile index 69fcf8d..23cf95a 100644 --- a/drivers/staging/ks7010/Makefile +++ b/drivers/staging/ks7010/Makefile @@ -1,4 +1,4 @@ obj-$(CONFIG_KS7010) += ks7010.o ccflags-y += -DKS_WLAN_DEBUG=0 -ks7010-y := michael_mic.o ks_hostif.o ks_wlan_net.o ks7010_sdio.o +ks7010-y := michael_mic.o hostif.o ks_wlan_net.o ks7010_sdio.o diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/hostif.c similarity index 99% rename from drivers/staging/ks7010/ks_hostif.c rename to drivers/staging/ks7010/hostif.c index 4561687..7d2ad52 100644 --- a/drivers/staging/ks7010/ks_hostif.c +++ b/drivers/staging/ks7010/hostif.c @@ -10,7 +10,7 @@ */ #include "ks_wlan.h" -#include "ks_hostif.h" +#include "hostif.h" #include "eap_packet.h" #include "michael_mic.h" diff --git a/drivers/staging/ks7010/ks_hostif.h b/drivers/staging/ks7010/hostif.h similarity index 100% rename from drivers/staging/ks7010/ks_hostif.h rename to drivers/staging/ks7010/hostif.h diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 9aff93d..6c10e3d 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -18,7 +18,7 @@ #include "ks_wlan.h" #include "ks_wlan_ioctl.h" -#include "ks_hostif.h" +#include "hostif.h" #include "ks7010_sdio.h" #define KS7010_FUNC_NUM 1 diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c index dfcef6f..b5609c1 100644 --- a/drivers/staging/ks7010/ks_wlan_net.c +++ b/drivers/staging/ks7010/ks_wlan_net.c @@ -34,7 +34,7 @@ static int wep_on_off; #define WEP_ON_128BIT 2 #include "ks_wlan.h" -#include "ks_hostif.h" +#include "hostif.h" #include "ks_wlan_ioctl.h" /* Include Wireless Extension definition and check version */ -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel