Re: [PATCH] staging: most: core: add autoconf ability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 21, 2017 at 09:37:38PM +0200, Christian Gromm wrote:
> On Fri, 21 Apr 2017 18:15:43 +0200
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > On Fri, Apr 21, 2017 at 05:36:43PM +0200, Christian Gromm wrote:
> > > 
> > > 
> > > On 04/20/2017 05:26 PM, Greg KH wrote:
> > > > On Thu, Apr 20, 2017 at 05:01:49PM +0200, Christian Gromm wrote:
> > > > > This patch extends the driver with the possibility of automatic
> > > > > configuration. This covers channel settings and connection
> > > > > establishing of a MOST device interface while it is registered
> > > > > with the core.
> > > > > 
> > > > > Making use of auto configuration will significantly cut the
> > > > > start-up overhead and the duration until the driver is
> > > > > available in userspace. Since the configuration depends on the
> > > > > type of network interface controller its setup and the
> > > > > peripheral interface, it can _not_ be part of the kernel and
> > > > > needs to be added once the system has been engineered.
> > > > 
> > > > I don't understand, what is using this new api you have added?
> > > > What is missing here?
> > > 
> > > What's missing is a module that holds the configuration, which looks
> > > basically like the sample module below. Once such a module is loaded
> > > along with the "regular" driver modules, configuration and linking
> > > of the channels is done automatically and you don't need any user
> > > space applications taking care of this.
> > > 
> > > But as stated in the commit message, this can't be part of the
> > > kernel tree since the information contained by this module heavily
> > > depends on what NIC is used, how it is configured and how the system
> > > designer wants to layout the network.
> > 
> > Well, I can never add an api to the kernel that no one uses, so this
> > isn't going to go very far at all.
> > 
> > Why don't you use DT for all of this?  It looks like that is exactly
> > what you are wanting to have your driver know.
> >
> 
> I understand the device tree as a description of the hardware layout
> and to let the kernel know about what HW is there. Never heard that it
> is (or can) used to configure certain modules.

What do you mean, it is used to configure modules (i.e. drivers) about
what hardware the platform has.  Which is what you want to do here,
right?  Your "hardware" (i.e. your network), is defined by the platform
it is running on.

Look at all of the stuff that DT is used to describe today, and if it
doesn't cover your use cases, please let us know.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux