This is a rework of a partially applied series with the same subject text (originally containing 18 patches). This is version 1 because the subject is not identical. The purpose of this patch set is to improve the readability of the SDIO code within the driver. Refactorings only, there are no changes to functionality introduced by this series. The ks7010 driver currently implements the WEXT interface. Currently, Wi-Fi kernel drivers are expected to use the CFG80211 interface. This series is a step towards that conversion. It will be easier to do the conversion if first the code is nice and clean. Patch 01 combines 4 preprocessor defines into an enumeration type, removing two which are unused. Patch 02 replaces preprocessor defines with enumeration types. Patch 03 fixes complete_handler() function prototype, this requires modification to a struct description and fixing all call sites. The prototype is included as a parameter in a number of functions, we fix these at the same time. Patch 04 cleans up header file comments, removes unneeded comments, adds structure kernel doc format comments. Patch 05 renames work_struct structure 'ks_wlan_wakeup_task' to 'wakeup_work'. Patch 06 moves tasklet_struct pointer into device private data structure. Patch 07 moves SDIO related members from hw_info_t structure into device private data structure. Patch 08 adds kernel doc format struct comments to structure used as SDIO func private data. Patch 09 cleans up the SDIO source code comments, removes unneeded comments and fixes comment typos. Patch 10 renames a goto label, removing the err_ prefix. Patch 11 fixes checkpatch space before tab warning. Patch 12 fixes checkpatch warning caused by multiple new lines. Patch 13 splits SDIO IO helper functions into two parts, simplifying the common case. Updates all call sites, including debug print statements. Patch 14 fixes checkpatch split string warning caused by debug print statement. Patch 15 renames 'ks7010_sdio.c' to 'sdio.c' and 'ks7010_sdio.h' to 'sdio.h'. Patch is the result of running the following two commands. $ git mv ks7010_sdio.c sdio.c $ git mv ks7010_sdio.h sdio.h Code is untested. Builds on x86_64 and PowerPC. Tobin C. Harding (15): staging: ks7010: create reg_status_type enum type staging: ks7010: replace defines with enum types staging: ks7010: fix complete_handler staging: ks7010: clean up SDIO header comments staging: ks7010: rename wakeup work struct staging: ks7010: move tasklet_struct to ks_wlan_private staging: ks7010: move hw info into dev private data staging: ks7010: add struct comment to ks_sdio_card staging: ks7010: clean up SDIO source comments staging: ks7010: remove err_ from non-error path label staging: ks7010: fix checkpatch SPACE_BEFORE_TAB staging: ks7010: fix checkpatch LINE_SPACING staging: ks7010: refactor SDIO read/write helpers staging: ks7010: fix checkpatch SPLIT_STRING staging: ks7010: rename SDIO files drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 1142 ---------------------------------- drivers/staging/ks7010/ks7010_sdio.h | 139 ----- drivers/staging/ks7010/ks_hostif.c | 55 +- drivers/staging/ks7010/ks_hostif.h | 7 +- drivers/staging/ks7010/ks_wlan.h | 10 +- drivers/staging/ks7010/ks_wlan_net.c | 12 +- drivers/staging/ks7010/sdio.c | 1079 ++++++++++++++++++++++++++++++++ drivers/staging/ks7010/sdio.h | 164 +++++ 9 files changed, 1284 insertions(+), 1326 deletions(-) delete mode 100644 drivers/staging/ks7010/ks7010_sdio.c delete mode 100644 drivers/staging/ks7010/ks7010_sdio.h create mode 100644 drivers/staging/ks7010/sdio.c create mode 100644 drivers/staging/ks7010/sdio.h -- 2.7.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
