On Mon, 17 Apr 2017 09:04:03 +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote: >> >> Macros more related to BLK operations. > > That doesn't make any sense to me, can you be more explicit?. skein_block.h contains all fn's related to processing on different block size so , it's more finer to contain macros that define block configuration, message,.. specially they aren't even referenced in all files that include skein_base.h but these macros I think still exist in driver files for future work as well. > Moving stuff from one file to another doesn't seem like it is really > worth it. > And where is patch 1/2 in this series? And, Moving stuff is what "TODO" see it is worth. There is no patch1/2 sorry, but may be because I sent the patch twice as one of the mails was witten wrong. >> Signed-off-by: Karim Eshapa <karim.eshapa@xxxxxxxxx> >> --- >> drivers/staging/skein/skein_base.h | 28 ---------------------------- >> drivers/staging/skein/skein_block.h | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 28 insertions(+), 28 deletions(-) Thanks, Karim _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
