Comparison should have the CONSTANT on the right side of the test Signed-off-by: Rishiraj Manwatkar <manwatkar@xxxxxxxxxxx> --- v1 -> v2: Added mailing list in cc. v2 -> v3: Improved Subject line. drivers/staging/lustre/lustre/obdclass/cl_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c index 0997254..bec112f 100755 --- a/drivers/staging/lustre/lustre/obdclass/cl_io.c +++ b/drivers/staging/lustre/lustre/obdclass/cl_io.c @@ -58,7 +58,7 @@ static inline int cl_io_type_is_valid(enum cl_io_type type) { - return CIT_READ <= type && type < CIT_OP_NR; + return type >= CIT_READ && type < CIT_OP_NR; } static inline int cl_io_is_loopable(const struct cl_io *io) @@ -389,7 +389,7 @@ void cl_io_unlock(const struct lu_env *env, struct cl_io *io) const struct cl_io_slice *scan; LASSERT(cl_io_is_loopable(io)); - LASSERT(CIS_IT_STARTED <= io->ci_state && io->ci_state < CIS_UNLOCKED); + LASSERT(io->ci_state >= CIS_IT_STARTED && io->ci_state < CIS_UNLOCKED); LINVRNT(cl_io_invariant(io)); set = &io->ci_lockset; -- 2.1.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel