On Thu, Apr 13, 2017 at 12:09:23AM -0700, skanda.kashyap@xxxxxxxxx wrote: > From: Skanda Guruanand <skanda.kashyap@xxxxxxxxx> > > Modified struct lu_dirpage in lustre_idl.h file to remove the sparse > warnings where cast to restricted types are made. > > Following warnings are removed by this fix. > > drivers/staging/lustre/lustre/mdc/mdc_request.c:958:42: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:959:42: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:962:42: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:963:42: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:985:50: warning: cast to restricted __le32 > drivers/staging/lustre/lustre/mdc/mdc_request.c:1193:24: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:1328:25: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:1329:23: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:1332:25: warning: cast to restricted __le64 > drivers/staging/lustre/lustre/mdc/mdc_request.c:1333:23: warning: cast to restricted __le64 > > Signed-off-by: Skanda Guruanand <skanda.kashyap@xxxxxxxxx> > --- > Isn't the below reason good enough? > Since the structure elements are always converted from little endian to processor native format > in mdc_request.c, struct lu_dirpage element types is modified. Why isn't this above in the changelog text? And I need an ack from a lustre maintainer before I can take this... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
