Re: [PATCH 1/2] staging: greybus: light.c: Remove include linux/version.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Darryl,
Thanks for the patch.
On Wed, Apr 12, 2017 at 08:36:14PM -0500, Darryl T. Agostinelli wrote:
Fixes:
$ make versioncheck | grep staging
./drivers/staging/greybus/light.c: 15 linux/version.h not needed.

Signed-off-by: Darryl T. Agostinelli <dagostinelli@xxxxxxxxx>
---
drivers/staging/greybus/light.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 8dffd8a..1681362 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -12,7 +12,6 @@
#include <linux/led-class-flash.h>
#include <linux/module.h>
#include <linux/slab.h>
-#include <linux/version.h>
#include <media/v4l2-flash-led-class.h>

#include "greybus.h"


You only forgot the version, v2, in patch subject.

But, Looks good to me:
Reviewed-by: Rui Miguel Silva <rmfrfs@xxxxxxxxx>

Cheers,
	Rui

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux