Re: [PATCH 1/5] staging: greybus: fixed ./drivers/staging/greybus/light.c: 15 linux/version.h not needed.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 11, 2017 at 11:01:15PM -0500, Darryl T. Agostinelli wrote:
>     $ make versioncheck | grep staging
>     ./drivers/staging/greybus/light.c: 15 linux/version.h not needed.
> 
>     Signed-off-by: Darryl T. Agostinelli <dagostinelli@xxxxxxxxx>

Why is everything indented here?

And your subject lines can be improved, look at how other commits do it
for these files.

And finally, always use scripts/get_maintainer.pl to properly cc: the
needed people for your patch.

Please fix all of these and resend this series.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux