Re: [PATCH] staging: rtl8723bs: core: drop unneeded null tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/08/2017 12:32 PM, Julia Lawall wrote:


On Sat, 8 Apr 2017, Hans de Goede wrote:

Hi Julia,

On 08-04-17 19:10, Julia Lawall wrote:
kfree returns immediately on NULL so the tests are not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Hans de Goede <hdegoede@xxxxxxxxxx>
Signed-off-by: Julia Lawall <julia.lawall@xxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>

Thank you for these patches. Larry Finger has just
posted a large cleanup series for the rtl8723bs
driver, which will likely conflict with these.

Can you rebase and resend these patches once Larry's
series has been merged please?

OK, thanks for the update.  There were a bunch of other coccicheck
warnings.  But I will wait for the improved version.

Julia,

Rather than fixing checkpatch or coccicheck problems, my intent is to now strip out unneeded code such as the part that handles 5G channels. That should make a lot of formatting patches not be needed. I did the Smatch fixes because a number of them were potentially able to cause crashes.

As I am not sure how soon I will be doing the next fixes, I will not submit any more patches until yours are rebased and merged.

Larry


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux