On Mon, Apr 03, 2017 at 10:25:37PM -0700, skanda.kashyap@xxxxxxxxx wrote:
> From: Skanda Guruanand <skanda.kashyap@xxxxxxxxx>
>
> Signed-off-by: Skanda Guruanand <skanda.kashyap@xxxxxxxxx>
Changelog text goes between those two lines, right?
>
> I have modified struct lu_dirpage as suggested in lustre_idl.h file
Why the extra ' '?
>
> CHECK drivers/staging/lustre/lustre/mdc/mdc_request.c
> drivers/staging/lustre/lustre/mdc/mdc_request.c:958:42: warning: cast
> to restricted __le64
Why is this all wrapped?
> drivers/staging/lustre/lustre/mdc/mdc_request.c:959:42: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:962:42: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:963:42: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:985:50: warning: cast
> to restricted __le32
> drivers/staging/lustre/lustre/mdc/mdc_request.c:1193:24: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:1328:25: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:1329:23: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:1332:25: warning: cast
> to restricted __le64
> drivers/staging/lustre/lustre/mdc/mdc_request.c:1333:23: warning: cast
> to restricted __le64
>
> ---
> drivers/staging/lustre/lustre/include/lustre/lustre_idl.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> index 60b827e..df48b8d 100644
> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
> @@ -846,10 +846,10 @@ struct luda_type {
> #endif
>
> struct lu_dirpage {
> - __u64 ldp_hash_start;
> - __u64 ldp_hash_end;
> - __u32 ldp_flags;
> - __u32 ldp_pad0;
> + __le64 ldp_hash_start;
> + __le64 ldp_hash_end;
> + __le32 ldp_flags;
> + __le32 ldp_pad0;
Are you sure this is correct? How was it tested?
Also, please fix your subject to properly match those already made for
this driver...
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
