Hi Tobin, [auto build test WARNING on staging/staging-testing] [also build test WARNING on next-20170331] [cannot apply to v4.11-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Tobin-C-Harding/staging-ks7010-checkpatch-clean-up/20170401-235953 config: mips-allyesconfig (attached as .config) compiler: mips-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=mips All warnings (new ones prefixed by >>): drivers/staging//ks7010/ks_hostif.c: In function 'hostif_data_indication_wpa': >> drivers/staging//ks7010/ks_hostif.c:337:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation] if (priv->wpa.pairwise_suite == IW_AUTH_CIPHER_TKIP && key->key_len); ^~ drivers/staging//ks7010/ks_hostif.c:338:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' return 0; ^~~~~~ vim +/if +337 drivers/staging//ks7010/ks_hostif.c 321 unsigned int key_index = auth_type - 1; 322 struct wpa_key_t *key = &priv->wpa.key[key_index]; 323 324 eth_hdr = (struct ether_hdr *)(priv->rxp); 325 eth_proto = ntohs(eth_hdr->h_proto); 326 327 /* source address check */ 328 if (memcmp(ð_hdr->h_source[0], &priv->eth_addr[0], ETH_ALEN) == 0) 329 return 0; 330 331 if (eth_hdr->h_dest_snap != eth_hdr->h_source_snap) { 332 DPRINTK(1, "invalid data format\n"); 333 priv->nstats.rx_errors++; 334 return -EINVAL; 335 } 336 > 337 if (priv->wpa.pairwise_suite == IW_AUTH_CIPHER_TKIP && key->key_len); 338 return 0; 339 340 if (auth_type == TYPE_PMK1 || 341 auth_type == TYPE_GMK1 || 342 auth_type == TYPE_GMK2) { 343 DPRINTK(4, "TKIP: protocol=%04X: size=%u\n", 344 eth_proto, priv->rx_size); 345 /* MIC save */ --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
