On Fri, Mar 31, 2017 at 11:53:55AM -0700, Joe Perches wrote: > On Fri, 2017-03-31 at 01:40 -0700, Chewie Lin wrote: > > fixed a coding style error/warning. > > > > Signed-off-by: Chewie Lin <linsh@xxxxxxxxxxxxxxx> > > --- > > drivers/staging/vt6656/main_usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c > > index 9e074e9..2d9e7af 100644 > > --- a/drivers/staging/vt6656/main_usb.c > > +++ b/drivers/staging/vt6656/main_usb.c > > @@ -414,7 +414,7 @@ static void usb_device_reset(struct vnt_private *priv) > > status = usb_reset_device(priv->usb); > > if (status) > > dev_warn(&priv->usb->dev, > > - "usb_device_reset fail status=%d\n", status); > > + "%s=%d\n", "usb_device_reset fail status", status); > > Yeah, what Greg said. > > Also most likely this should be > > dev_warn(&priv->usb->dev, > "usb_reset_device fail status=%d\n", status); > > Note the function is usb_device_reset, but the > function call that failed is usb_reset_device. yep, I had the comic book guy from the Simpsons voice when I read that. :) I submitted a separate patch, maybe I should have reply-to this instead? > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
