> The code is untested, I have hardware in the mail. Cool! > If any one is interested and has any comments I would really like to > hear them. I am open to all suggestions (even down to trivial coding > style issues). I'll just repeat that the key move to get this driver out of staging is to get away from the WEXT interface to CFG80211. Otherwise no chance that wireless maintainers will even look at it. This is a huge change but once it is done, features like Michael MIC come with it for free (from what I recall, I am not a wireless expert myself). Without the CFG80211 conversion, replacing the Michael custom implementation with the in-kernel one makes the driver a tad better and is good exercise. However, it will sadly not help to get the driver out of staging. But if you want a clean WEXT driver first, this is a step in the right direction.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
